Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the conda build with RMM 23.02 #348

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Fix the conda build with RMM 23.02 #348

merged 2 commits into from
Jul 7, 2023

Conversation

mdemoret-nv
Copy link
Contributor

Description

The conda build failed on the RMM 23.02 variant as shown here due to the change with moving RMM_LOGGING_ASSERT between versions 23.02 and 23.04.

This fix removes uses of RMM_LOGGING_ASSERT replacing it with the equivalent DCHECK which is used throughout the rest of the repo.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mdemoret-nv mdemoret-nv requested a review from a team as a code owner July 7, 2023 15:49
@mdemoret-nv mdemoret-nv added bug Something isn't working non-breaking Non-breaking change labels Jul 7, 2023
@mdemoret-nv mdemoret-nv requested a review from a team as a code owner July 7, 2023 15:58
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #348 (bd1f6fd) into branch-23.07 (17a7c07) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           branch-23.07     #348   +/-   ##
=============================================
  Coverage         73.11%   73.11%           
=============================================
  Files               382      382           
  Lines             13403    13403           
  Branches           1010     1011    +1     
=============================================
  Hits               9800     9800           
  Misses             3603     3603
Flag Coverage Δ
cpp 69.04% <0.00%> (ø)
py 42.06% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/include/mrc/memory/resources/arena_resource.hpp 68.29% <ø> (ø)
.../mrc/include/mrc/memory/resources/detail/arena.hpp 72.48% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17a7c07...bd1f6fd. Read the comment docs.

@mdemoret-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5f62b46 into nv-morpheus:branch-23.07 Jul 7, 2023
@mdemoret-nv mdemoret-nv deleted the mdd_fix-conda-build-22.06 branch July 7, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drobison00 drobison00 drobison00 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdemoret-nv @drobison00